RFR: universal type variables: initial prototype [v3]

Vicente Romero vromero at openjdk.java.net
Wed Aug 11 04:48:36 UTC 2021


On Tue, 10 Aug 2021 21:16:05 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   second iteration of review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 2663:
> 
>> 2661:                         && ((JCFieldAccess)tree.meth).selected.hasTag(IDENT)
>> 2662:                         && TreeInfo.name(((JCFieldAccess)tree.meth).selected) == names._super;
>> 2663:                 boolean qualifierIsUniversal = allowUniversalTVars && qualifier.hasTag(TYPEVAR) && ((TypeVar)qualifier).isValueProjection();
> 
> This should be `isUniversal()` I think - `wait` and friends should warn, even on `.ref` stuff.

not sure to be honest, although there is no reference in the JEP to these warnings so we can do either now

-------------

PR: https://git.openjdk.java.net/valhalla/pull/521


More information about the valhalla-dev mailing list