[lworld] RFR: 8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed [v2]

Mandy Chung mchung at openjdk.java.net
Thu Aug 12 17:40:55 UTC 2021


On Wed, 11 Aug 2021 04:38:00 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> If any of the following VM options have different values between CDS dump time and runtime, we cannot load the CDS archive:
>> 
>> - `FlatArrayElementMaxOops`
>> - `FlatArrayElementMaxSize`
>> - `InlineFieldMaxFlatSize`
>> - `InlineTypePassFieldsAsArgs`
>> - `InlineTypeReturnedAsFields`
>> 
>> Testing with mach5 tiers 1-2
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed test failures; improved error message

Marked as reviewed by mchung (Committer).

@ioilam Thanks for fixing this.  To give more context, this issue was uncovered when the CDS archive includes primitive classes such as `Optional` which is converted to a ref-default primitive class.   The tests fail when running with CDS sharing enabled but pass when running with -Xshare:off.

This looks fine to me.  It'd be good to have someone from the runtime to review it.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/526


More information about the valhalla-dev mailing list