RFR: universal type variables: initial prototype [v4]

Vicente Romero vromero at openjdk.java.net
Thu Aug 12 19:16:49 UTC 2021


On Thu, 12 Aug 2021 18:34:01 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments, another iteration
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 1991:
> 
>> 1989:             this.isReferenceProjection = isReferenceProjection;
>> 1990:             this.isUniversal = (tsym.flags_field & UNIVERSAL) != 0;
>> 1991:             if (isUniversal && !isReferenceProjection) {
> 
> isn't `isReferenceProjection` always `false` here (you have just created the class)

not really, because this constructor is used again to build the reference, so I have to add it to the condition to avoid stackoverflow errors

-------------

PR: https://git.openjdk.java.net/valhalla/pull/521


More information about the valhalla-dev mailing list