[lworld] RFR: 8272290: [lworld] Disable CDS if InlineTypePassFieldsAsArgs has changed [v2]

Ioi Lam iklam at openjdk.java.net
Mon Aug 16 00:57:08 UTC 2021


On Thu, 12 Aug 2021 17:37:42 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed test failures; improved error message
>
> @ioilam Thanks for fixing this.  To give more context, this issue was uncovered when the CDS archive includes primitive classes such as `Optional` which is converted to a ref-default primitive class.   The tests fail when running with CDS sharing enabled but pass when running with -Xshare:off.
> 
> This looks fine to me.  It'd be good to have someone from the runtime to review it.

Thanks @mlchung and @fparain for the review.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/526


More information about the valhalla-dev mailing list