[lworld] RFR: Convert valhalla/inlinetypes tests to new IR framework

Tobias Hartmann thartmann at openjdk.java.net
Mon Jul 12 09:56:30 UTC 2021


On Mon, 21 Jun 2021 21:38:43 GMT, Ekaterina Pavlova <epavlova at openjdk.org> wrote:

> This PR converts compiler/valhalla/inlinetypes tests based on old Valhalla/IR test framework to new one 
> which was recently integrated by Christian as part of JDK-8254129.
> The tests which were we decided to convert are basically the ones which extends InlineTypeTest class.
> The rest of compiler/valhalla/inlinetypes tests were agreed (with Christian and Tobias) to keep untouched 
> as they are in most cases regression tests.
> 
> The conversion rules/approach is pretty well described in the bug's description section (see JDK-8263024).
> A detailed description of new IR test framework could found in test/hotspot/jtreg/compiler/lib/ir_framework/README.md.
> 
> Testing:
>  Ran compiler/valhalla/inlinetypes in all the configurations used in hs-tier1-9.
>  There 2 failed converted tests:
>   compiler/valhalla/inlinetypes//TestNullableArrays.java - new bug JDK-8269070 filed
>   compiler/valhalla/inlinetypes/TestIntrinsics.java - know issue tracked by JDK-8239003
> 
> 
> Big thanks to Christian and Tobias for advice and help during this tests conversion.
> 
> Please review the changes.
> 
> Thanks,
> Katya

Thanks a lot for taking care of this, Katya! The changes look good to me, just TestIntrinsics.java needs merging.

Please link JDK-8263024 to the PR.

Best regards,
Tobias

-------------

Marked as reviewed by thartmann (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/457


More information about the valhalla-dev mailing list