[lworld] RFR: 8263024: Convert Valhalla tests using the old framework to the new framework [v2]

Ekaterina Pavlova epavlova at openjdk.java.net
Tue Jul 13 23:50:35 UTC 2021


On Tue, 13 Jul 2021 07:56:08 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Ekaterina Pavlova has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge lworld
>>  - Converted to new IR framework
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestLWorldProfiling.java line 569:
> 
>> 567:     // branch frequency profiling causes not equal branch to be optimized out
>> 568:     @Test
>> 569:     @IR(failOn = {SUBSTITUTABILITY_TEST})
> 
> Can be simplified to `failOn = SUBSTITUTABILITY_TEST`. There are some more of them below which could be simplified as well.

I actually specially kept {} so it will be more straightforward to add more nodes if needed. But I can remove {} if you prefer simplified version.

> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestNullableArrays.java line 124:
> 
>> 122:     // updating its elements in a loop and computing a hash.
>> 123:     @Test
>> 124:     @IR(failOn = {ALLOCA})
> 
> Can be simplified to `failOn = ALLOCA`.

see previous comment

> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestNullableArrays.java line 2567:
> 
>> 2565:     // Test loads from vararg arrays
>> 2566:     @Test
>> 2567:     @IR(failOn = {LOAD_UNKNOWN_INLINE})
> 
> Can be simplified to `failOn = LOAD_UNKNOWN_INLINE`.

see previous comment

-------------

PR: https://git.openjdk.java.net/valhalla/pull/457


More information about the valhalla-dev mailing list