[lworld] RFR: 8263024: Convert Valhalla tests using the old framework to the new framework [v3]
epavlova at openjdk.java.net
Wed Jul 14 05:32:16 UTC 2021
> This PR converts compiler/valhalla/inlinetypes tests based on old Valhalla/IR test framework to new one
> which was recently integrated by Christian as part of JDK-8254129.
> The tests which were we decided to convert are basically the ones which extends InlineTypeTest class.
> The rest of compiler/valhalla/inlinetypes tests were agreed (with Christian and Tobias) to keep untouched
> as they are in most cases regression tests.
> The conversion rules/approach is pretty well described in the bug's description section (see JDK-8263024).
> A detailed description of new IR test framework could found in test/hotspot/jtreg/compiler/lib/ir_framework/README.md.
> Ran compiler/valhalla/inlinetypes in all the configurations used in hs-tier1-9.
> There 2 failed converted tests:
> compiler/valhalla/inlinetypes//TestNullableArrays.java - new bug JDK-8269070 filed
> compiler/valhalla/inlinetypes/TestIntrinsics.java - know issue tracked by JDK-8239003
> Big thanks to Christian and Tobias for advice and help during this tests conversion.
> Please review the changes.
Ekaterina Pavlova has updated the pull request incrementally with one additional commit since the last revision:
Fixes based on Christian's comments
- all: https://git.openjdk.java.net/valhalla/pull/457/files
- new: https://git.openjdk.java.net/valhalla/pull/457/files/63bdc6f2..1e1dbe1d
- full: https://webrevs.openjdk.java.net/?repo=valhalla&pr=457&range=02
- incr: https://webrevs.openjdk.java.net/?repo=valhalla&pr=457&range=01-02
Stats: 34 lines in 7 files changed: 9 ins; 5 del; 20 mod
Fetch: git fetch https://git.openjdk.java.net/valhalla pull/457/head:pull/457
More information about the valhalla-dev