[lworld] RFR: 8263024: Convert Valhalla tests using the old framework to the new framework [v3]

Christian Hagedorn chagedorn at openjdk.java.net
Wed Jul 14 15:53:56 UTC 2021


On Wed, 14 Jul 2021 05:32:16 GMT, Ekaterina Pavlova <epavlova at openjdk.org> wrote:

>> This PR converts compiler/valhalla/inlinetypes tests based on old Valhalla/IR test framework to new one 
>> which was recently integrated by Christian as part of JDK-8254129.
>> The tests which were we decided to convert are basically the ones which extends InlineTypeTest class.
>> The rest of compiler/valhalla/inlinetypes tests were agreed (with Christian and Tobias) to keep untouched 
>> as they are in most cases regression tests.
>> 
>> The conversion rules/approach is pretty well described in the bug's description section (see JDK-8263024).
>> A detailed description of new IR test framework could found in test/hotspot/jtreg/compiler/lib/ir_framework/README.md.
>> 
>> Testing:
>>  Ran compiler/valhalla/inlinetypes in all the configurations used in hs-tier1-9.
>>  There 2 failed converted tests:
>>   compiler/valhalla/inlinetypes//TestNullableArrays.java - new bug JDK-8269070 filed
>>   compiler/valhalla/inlinetypes/TestIntrinsics.java - know issue tracked by JDK-8239003
>> 
>> 
>> Big thanks to Christian and Tobias for advice and help during this tests conversion.
>> 
>> Please review the changes.
>> 
>> Thanks,
>> Katya
>
> Ekaterina Pavlova has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes based on Christian's comments

Thanks for doing the changes!

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestCallingConventionC1.java line 179:

> 177:         @DontInline
> 178:         @ForceCompile(CompLevel.C1_SIMPLE)
> 179:         public int func1(int a, int b)             { return field + a + b + 20; }

Can you also add a new line here?

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestCallingConventionC1.java line 190:

> 188:         @DontInline
> 189:         @ForceCompile(CompLevel.C2)
> 190:         public int func1(int a, int b)             { return field + a + b + 20; }

And here

-------------

Marked as reviewed by chagedorn (no project role).

PR: https://git.openjdk.java.net/valhalla/pull/457


More information about the valhalla-dev mailing list