[lworld] Integrated: 8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"

Tobias Hartmann thartmann at openjdk.java.net
Tue Jul 27 08:06:08 UTC 2021


On Mon, 26 Jul 2021 11:56:47 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> The `G1BarrierSetC2::step_over_gc_barrier` code gets confused by a `MemBarCPUOrder`, assuming it belongs to a GC barrier. However, it comes from a `MemBarStoreStore` added by `InlineTypeBaseNode::buffer` that is then transformed to a `MemBarCPUOrder` by Escape Analysis because the allocation is non-escaping (`ConnectionGraph::optimize_ideal_graph`). I don't think we need a `MemBarCPUOrder` for inline type buffer allocations, EA should simply remove it.
> 
> I've filed [JDK-8271280](https://bugs.openjdk.java.net/browse/JDK-8271280) to re-visit the barrier code.
> 
> Best regards,
> Tobias

This pull request has now been integrated.

Changeset: 61602384
Author:    Tobias Hartmann <thartmann at openjdk.org>
URL:       https://git.openjdk.java.net/valhalla/commit/616023843b10876dcd3b0e3dd49534b6e48b274f
Stats:     106 lines in 3 files changed: 95 ins; 5 del; 6 mod

8270995: [lworld] G1BarrierSetC2::step_over_gc_barrier asserts with "bad barrier shape"

-------------

PR: https://git.openjdk.java.net/valhalla/pull/495


More information about the valhalla-dev mailing list