[lworld] RFR: 8271309: [lworld] FieldModification event: new_value is invalid for Q objects

Frederic Parain fparain at openjdk.java.net
Tue Jul 27 20:55:51 UTC 2021


On Tue, 27 Jul 2021 01:06:21 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> The fix adds handling of Q-type fields the same way as L-type

Hi Alex,

Thank you for fixing this. Overall, looks good to me.

Many of the tests related to the FieldModification event are still not working (they are commented with a KNOWN ISSUE comment) because the withfield bytecode still doesn't support JVMTI FieldModification event. Do you have a CR to track this issue?

Regards,

Fred

test/hotspot/jtreg/serviceability/jvmti/Valhalla/FieldAccessModify/libFieldAccessModify.cpp line 139:

> 137:     // For FieldModification event print current value.
> 138:     // Note: this will cause FieldAccess event.
> 139:     if (modified) {

It would be cleaner to have modified be declared as a bool, or to re-write the test to modified == 1.

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/499


More information about the valhalla-dev mailing list