RFR: L/Q again, step two

Rémi Forax github.com+828220+forax at openjdk.java.net
Tue May 18 19:58:28 UTC 2021


On Tue, 18 May 2021 19:00:15 GMT, Frederic Parain <fparain at openjdk.org> wrote:

> Please review this second set of fixes for the L/Q transition.
> A few changes in C1, most changes in CI.
> CI always delegates to the runtime to know if a null-free array is flattened or not (to avoid duplication of the flattening decision code).
> 
> With those changes, all tests in runtime/valhalla/inlinetypes now pass with -Xcomp -XX:TieredStopAtLevel=1 (at least on Linux x64).
> Some tests in compiler/valhalla/inlinetypes still fail but they will require more time to be investigated (some tests force use of C2 or expect code to be C2 compiled, but C2 is not fixed yet).
> 
> Thank you,
> 
> Fred

test/hotspot/jtreg/runtime/valhalla/inlinetypes/MultiANewArrayTest/MultiANewArrayTest.java line 52:

> 50:             ex = e;
> 51:         }
> 52:         Asserts.assertNull(ex, "No ICCE should have been thrown");

The negation of "An ICCE should have been thrown" is "No error should have been thrown",
talking about ICCE it that context can be misleading.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/414


More information about the valhalla-dev mailing list