Please review fix - approved
philip.race at oracle.com
Fri Jun 18 10:38:05 PDT 2010
I see what you mean. I'm not sure how the raw file was created or last
edited but that
is actually the original shared file, and its like that in the
"raw_files" from Clemen's
last webrev generated on 20th April. So the new solaris one is really a
just "cp'd" to the solaris location and I then edited the shared one which
does have a final newline.
So it does work, I guess a missing final newline messes up at least my
version of webrev .. which is the shared one on the internal devtools
But I'll give it a trailing new line anyway.
On 6/18/2010 12:58 AM, Andrew Brygin wrote:
> Hi Phil,
> fix looks fine to me.
> BTW, it looks like that 'New' representation for
> misses the last line, that looks a bit misleading. Corresponding raw
> file and patch look fine though.
> Phil Race wrote:
>> Clemens and Andrew,
>> has the fix for being unable to load the JulesRenderingEngine
>> as service in openjdk on windows.
>> The fix is simply to revert the shared file and make a new
>> solaris/linux file which references Jules.
>> Without this fix openjdk is dead on Windows.
More information about the xrender-dev