[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Jim Graham Jim.A.Graham at Sun.COM
Thu Sep 17 20:27:32 UTC 2009

I can't speak for the changes to the build files, but I only have a 
couple of very small suggestions for the code changes.

Our coding style for continued class declarations would suggest using 
the following indentation:

public class FooPipe extends SomeKindaPipe
     implements LoopBasedPipe

with the "{" on a new line by its own after the implements clause, and 
indentations of 4 spaces (see LoopPipe).

Also, the interface was not represented in the webrevs and its name 
should be singular (not "Pipes")...


Mario Torre wrote:
> Il 05/08/2009 10:37, Mario Torre ha scritto:
>> I'll send you an update shortly based on the latest OpenJDK checkout 
>> even.
> So, "shortly" turned out to be more than one month.....
> I'm so sorry, I had quite few problems at work and some personal stuff 
> as well that kept me quite busy on other stuff. Anyway, here is an 
> update of the patch with the suggestions from the last comment:
> http://cr.openjdk.java.net/~neugens/100068/webrev.07/
> I hope it's fine this time :)
> Cheers,
> Mario

More information about the 2d-dev mailing list