[OpenJDK 2D-Dev] Suggest a modification to isPostscript exception handling

Sean Chou zhouyx at linux.vnet.ibm.com
Thu Aug 23 06:24:47 UTC 2012


     This is a simple modification to sun/print/PSPrinterJob.java.
     When sun.print.IPPPrintService.isPostscript method checks if the
printer is a postscript printer, if IOException happens, the method assumes
the printer is postscript printer (IPPPrintService.java, line 1605). In
class PSPrinterJob, it invoke isPostscript and assumes all  Throwables to
be a postscript printer ( PSPrinterJob.java, line 625 ).  I think it should
return false in cases exceptions other than IOException are
caught, IOException should not be expanded to all Throwable.

The webrev is at: http://cr.openjdk.java.net/~zhouyx/OJDK-429/webrev.00/  .

Please take a look.

Best Regards,
Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20120823/6e6fa064/attachment.html>

More information about the 2d-dev mailing list