[OpenJDK 2D-Dev] [8] request for review: 7153693: Three 2D_ImageIO tests failed due ImageFormatException on OEL 6.* Unbreakable Kernel x64

Andrew Brygin andrew.brygin at oracle.com
Sat Jun 9 08:50:53 UTC 2012


  could you please review a fix for 7153693?

  This problem is caused by incorrect usage of memcpy routine in
  sun_jpeg_fill_suspended_buffer. The linux man for memcpy says:

"The memory areas must not overlap. Use memmove(3) if the memory areas 
do overlap."

  This is exactly the case of the sun_jpeg_fill_suspended_buffer, were
  we move overlapped memory areas under some conditions. Some linux
  systems are tolerant to the problem, but OEL 6.* Unbreakable Kernel
  x64 is not, so the problem is visible there, and manifests
  in occasional  failures during decoding of progressive jpegs.
  It is the root cause of observed test failures.

  Suggested fix is just use memmove instead of memcpy.

  Please take a look.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153693
Webrev: http://cr.openjdk.java.net/~bae/7153693/8/webrev.00/


More information about the 2d-dev mailing list