[OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Jun 19 18:00:08 UTC 2012

Hi, Phil.
But some time ago in the jdk all .startsWith("Mac OS X") or 
were replaced by ".contains("OS X")"
In print area also, see changes in UnixPrintServiceLookup.isBSD().

As far as I know Apple officially drops Mac from "Mac OS X" name.

On 19.06.2012 20:49, Phil Race wrote:
> startsWith("Mac") is what we use in FX and I don't see a problem with it
> and its surely more reliable to type and efficient than contains("OS X");
> If its meant to be targeted to a specific version that could break if 
> there's an OS XI ..
> And startsWith("Win") is a common pattern. So I don't agree with the 
> advice
> anyway.
> -phil.
> On 6/19/2012 9:36 AM, Sergey Bylokhov wrote:
>> Hi,Phil.
>> According to these CR macosx check should be: .contains("OS X").
>> http://monaco.sfbay.sun.com/detail.jsf?cr=7147461
>> http://monaco.sfbay.sun.com/detail.jsf?cr=7130404
>> On 19.06.2012 20:13, Phil Race wrote:
>>> 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() 
>>> return null
>>> http://cr.openjdk.java.net/~prr/7124536.7u6/
>>> -phil.

Best regards, Sergey.

More information about the 2d-dev mailing list