[OpenJDK 2D-Dev] Request for review: updated 2 files to use generic type
philip.race at oracle.com
Thu Jun 21 13:07:31 UTC 2012
You are still generating a patch against the T+L forest.
For 2D fixes it should be generated against the 2D forest.
I don't see a lot of value in generification to Object .. is there
some practical value to this ?
On 6/21/12 1:36 AM, Sean Chou wrote:
> Any one would like to take a look at this ?
> ---------- Forwarded message ----------
> From: *Sean Chou* <zhouyx at linux.vnet.ibm.com
> <mailto:zhouyx at linux.vnet.ibm.com>>
> Date: Tue, Jun 19, 2012 at 4:00 PM
> Subject: Request for review: updated 2 files to use generic type
> To: 2d-dev at openjdk.java.net <mailto:2d-dev at openjdk.java.net>
> Hi all,
> I updated 2 files(src/share/classes/sun/font/StrikeCache.java,
> src/share/classes/sun/java2d/Disposer.java) to use generic type, and
> updated several old version generic to diamond(<>), a type from Object
> to Void ; and by the way an invocation to a static method.
> In order to get a ReferenceQueue<object> in StrikeCache.java
> I changed the return type of Disposer.getQueue from ReferenceQueue to
> ReferenceQueue<Object> .
> The webrev is at:
> <http://cr.openjdk.java.net/%7Ezhouyx/OJDK-389/webrev.01/> .
> Some comments collected as I didn't send the mail to the right mailing
> Best Regards,
> Sean Chou
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev