[OpenJDK 2D-Dev]  request for review JDK-8000176
vadim.pakhnushev at oracle.com
Fri Oct 5 11:54:53 UTC 2012
I've added these 2 lines to the test, Andrew will push updated version.
On 05.10.2012 0:08, Phil Race wrote:
> I'm OK with it too although since xrender isn't applicable to Windows,
> either True or false is actually
> testing the default (hopefully d3d) pipeline there.
> If you wanted to thoroughly test , including windows as well you could add
> 2 more lines
> @run main/othervm -Dsun.java2d.d3d=false InterpolationQualityTest
> @run main/othervm -Dsun.java2d.d3d=True InterpolationQualityTest
> On any platform where any of these options isn't applicable I
> think it'll be ignored, so you'll run the default twice, but that's OK.
> On 10/3/12 7:00 AM, Andrew Brygin wrote:
>> Hello Vadim,
>> the test looks fine to me.
>> On 03.10.2012 17:41, Vadim Pakhnushev wrote:
>>> I've made changes according to Andrew Brygin's feedback:
>>> Created unified drawTestImage method so reference and tested images
>>> are rendered from one place.
>>> Simplified renderImage method to eliminate nested while loop.
>>> webrev: http://cr.openjdk.java.net/~bae/8000176/webrev.01/
>>> On 28.09.2012 16:20, Vadim Pakhnushev wrote:
>>>> Please review automated test which checks that accelerated
>>>> pipelines correctly use interpolation rendering hints.
>>>> Discussion of the bug for which the test was created:
>>>> webrev: http://cr.openjdk.java.net/~bae/8000176/webrev.00/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev