[OpenJDK 2D-Dev] pls review jdk 7 fix for 8015334
Steven R. Loomis
steven.loomis at oracle.com
Thu Jun 20 06:19:36 UTC 2013
Looks good to me.
On 6/19/13 10:42 a.m., Phil Race wrote:
> I revamped the test to scrap the unnecessary swing stuff.
> No invokeLater needed anymore.
> Nothing else has changed.
> On 6/19/2013 5:28 AM, Andrew Brygin wrote:
>> Hello Phil,
>> The fix looks fine to me.
>> However, the test does not work correctly with jtreg harness:
>> for some reasons, jtreg reports success immediately after
>> so actual testing is not performed. The option 'othervm' does not
>> help: the test reports success anyway.
>> This behavior seems to be a bug in the jtreg harness. It could be
>> by an explicit synchronization between main and EDT threads.
>> Also, the @test tag needs to be added to the test header.
>> On 6/19/2013 1:49 AM, Phil Race wrote:
>>> Steven & Andrew,
>>> I believe 8015334 : Memory leak in Kerning should be ported to 7u40.
>>> Please sanity check this fix which is the same as the already pushed
>>> JDK 8 fix :
>>> http://cr.openjdk.java.net/~prr/8015334.jdk7/ then I'll see if it'll
>>> accepted into the 7u40 stabilisation forest.
More information about the 2d-dev