[OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452

Phil Race philip.race at oracle.com
Mon Oct 28 22:03:53 UTC 2013

Sorry for the delay in replying to this but I don't think you should 
specify these options
* @run main/othervm -Dsun.java2d.xrender=True TextRenderingTest

1 - othervm is frowned on these days as it slows down testing
2. If the reason you are using it is to pass in the VM option, then its not
right here. You are forcing the (platform specific) pipeline to be on 
the better judgement of the pipeline. The test is only valid if the pipeline
decides its valid.


On 9/13/2013 5:58 AM, Andrew Brygin wrote:
> Hi Alexander,
>  the test looks fine to me.
> Thanks,
> Andrew
> On 9/13/2013 1:20 PM, alexander stepanov wrote:
>> Hello,
>> could you please review the fix for the following [TEST] bug:
>> https://bugs.openjdk.java.net/browse/JDK-8024767
>> (sorry, the bug info isn't available at bugs.sun.com yet).
>> The webrev corresponding:
>> http://cr.openjdk.java.net/~bae/8024767/webrev.00/
>> Just a new test added; no other code affected.
>> The patch contains a simple automated test (check if source offset 
>> for text rendering is handled correctly).
>> Thanks.
>> Regards,
>> Alexander

More information about the 2d-dev mailing list