[OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452
alexander.v.stepanov at oracle.com
Tue Oct 29 12:48:58 UTC 2013
OK, thanks, I'll remove the redundant options.
On 29.10.2013 2:03, Phil Race wrote:
> Sorry for the delay in replying to this but I don't think you should
> specify these options
> * @run main/othervm -Dsun.java2d.xrender=True TextRenderingTest
> 1 - othervm is frowned on these days as it slows down testing
> 2. If the reason you are using it is to pass in the VM option, then
> its not
> right here. You are forcing the (platform specific) pipeline to be on
> the better judgement of the pipeline. The test is only valid if the
> decides its valid.
> On 9/13/2013 5:58 AM, Andrew Brygin wrote:
>> Hi Alexander,
>> the test looks fine to me.
>> On 9/13/2013 1:20 PM, alexander stepanov wrote:
>>> could you please review the fix for the following [TEST] bug:
>>> (sorry, the bug info isn't available at bugs.sun.com yet).
>>> The webrev corresponding:
>>> Just a new test added; no other code affected.
>>> The patch contains a simple automated test (check if source offset
>>> for text rendering is handled correctly).
More information about the 2d-dev