[OpenJDK 2D-Dev] Request for review: JDK-6870661 Setting a custom PrintService on a PrinterJob leads to a PrinterException
patrick at reini.net
Mon Sep 23 20:15:41 UTC 2013
Did you had the time to look into it jet?
Am 16.09.13 22:19, schrieb Patrick Reinhart:
> Hi Phil,
> Thanks for the quick response, seems I need some more practice in
> English ;-)
> Cheers Patrick
> Am 16.09.13 18:59, schrieb Phil Race:
>> It looks OK to me although the test has typoes.
>> Marings => Margins
>> Appearence -> Appearance
>> Jennifer : can you review too - then test and commit - with typoes
>> On 9/15/2013 2:43 AM, Patrick Reinhart wrote:
>>> I need a sponsor and reviewer for my fix at
>>> Problem description:
>>> When setting a custom implemented PrintService on a PrinterJob under
>>> Windows, a exception is thrown.
>>> If the custom implementation extends a StreamPrintService,
>>> everything works fine.
>>> Fix description:
>>> I changed the behaviour for the windows specific part being used
>>> only for instances of Win32PrintService.
>>> So all non Win32PrintService print services will behave as non-native.
>>> I also included a small regression test to prove my fix.
More information about the 2d-dev