[OpenJDK 2D-Dev] RFR: 8064833 : [macosx] Native font lookup uses family+style, not full name/postscript name
Sergey.Bylokhov at oracle.com
Mon Dec 29 11:11:22 UTC 2014
The fix looks fine. Note that necessary tags are absent in the test
On 24.12.2014 0:30, Phil Race wrote:
> On 12/23/2014 11:10 AM, Sergey Bylokhov wrote:
>> Hi, Phil.
>> Probably it is possible to move the new code in
>> CFontManager.loadFonts() to the SunFontManager.loadFonts()?
> No .. its completely mac-specific.
>> Note that in the test the text "Big italic red text" should be
>> ..."black text",
> that was taken from the original bug.
>> and the window should be disposed at the end of the test.
> I can update the test before I push.
> > Why this test is mac specific?
> Because the whole problem is mac-specific and you can't find the
> with the fonts that cause this problem elsewhere. Its really iffy to
> test at all ..
> Note that I am using glyphcodes, which means you have to know exactly
> what font you have.
>> On 15.12.2014 23:20, Phil Race wrote:
>>> OS X font look up is using family name + style - even when using
>>> from a specific font. Since the family name like "Helvetica" is
>>> insufficient to
>>> convey that you are using the "Helvetica Light" subfamily and we get
>>> wronf font.
>>> The provided test shows that the results can be completely garbage
>>> Some clean up included here is remove the unconditional define of
>>> DEBUG and
>>> the native 'isFakeItalic' variable which was not used anywhere.
Best regards, Sergey.
More information about the 2d-dev