[OpenJDK 2D-Dev]  Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth
philip.race at oracle.com
Mon Jul 7 21:45:25 UTC 2014
Since its returning an array index into theIHDR_bitDepths array I think
this should be written as
IHDR_bitDepth =IHDR_bitDepths[getEnumeratedAttribute(node, "bitDepth", IHDR_bitDepths)];
.. but ensuring the line <=80 chars long
Also note that this is a complete duplicate of
Always remember to look for duplicates !
So I have closed 8041460 and you should push under 4991647 - once
the code is fixed and reviewed.
I have assigned 4991647 to you.
On 6/23/2014 6:09 AM, Andrew Brygin wrote:
> Hello Mikhail,
> the fix looks fine to me.
> On 6/9/2014 10:32 PM, mikhail cherkasov wrote:
>> Hi all,
>> please review the fix:
>> for the following bug:
>> The problem is that during merging of metadata trees we take index of
>> and set this value to IHDR_bitDepth, but IHDR_bitDepth requires a
>> real number of bits.
>> IHDR_bitDepths - store all valid values: "1", "2", "4", "8", "16", so
>> to get
>> valid value we need: 1 << index.
More information about the 2d-dev