[OpenJDK 2D-Dev] RFR: 8052396: Catch exceptions resulting from missing font cmap
Sergey.Bylokhov at oracle.com
Thu Jul 31 18:13:20 UTC 2014
The fix looks good.
On 7/31/14 9:34 PM, Phil Race wrote:
> http://cr.openjdk.java.net/~prr/8052396.1 adds a break to keep
> findbugs happy.
> 2nd reviewer anyone ?
> On 07/28/2014 11:28 PM, Andrew Brygin wrote:
>> Hello Phil,
>> in general, the change looks fine to me.
>> The only concern is whether the code at FileFontStrike.java lines
>> 498 - 506
>> triggers tools like findbug due to missed 'break' statement. Does it
>> to add 'break' there?
>> On 7/29/2014 2:30 AM, Phil Race wrote:
>>> This is a robustness fix. Nothing changes unless we
>>> get exceptions indexing glyphs. This has been seen only
>>> in a stress test at the same time as exiting the VM.
Best regards, Sergey.
More information about the 2d-dev