[OpenJDK 2D-Dev] <AWT Dev> Dont use libjpeg-internal macros in splashscreen
anthony.petrov at oracle.com
Mon May 5 14:12:21 UTC 2014
The fix looks good to me, too.
On 5/1/2014 1:19 AM, Phil Race wrote:
> Trying again with awt as "To:" rather than bcc: ..
> On 4/30/2014 2:12 PM, Phil Race wrote:
>> Looks OK to me, but adding awt-dev as splashscreen is owned by AWT.
>> On 4/30/2014 1:48 PM, Omair Majid wrote:
>>> As indicated in the libjpeg API documentation , the standard libjpeg
>>> headers are: jpeglib.h, jerror.h, jconfig.h, jmorecfg.h.
>>> splashscreen_jpeg.c violates this layering and uses the SIZEOF macro
>>> from the non-public header jinclude.h directly. This macro is a wrapper
>>> over sizeof. The code in splashscreen_jpeg.c already uses sizeof in
>>> multiple places so it seems like it should be okay to use it in some
>>> The following webrev fixes it:
>>> One motivation of having this patch is that if/when we add
>>> system-libjpeg support, the header jinclude.h will become inaccessible.
>>>  http://svn.code.sf.net/p/libjpeg-turbo/code/trunk/libjpeg.txt
More information about the 2d-dev