[OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code
mandy.chung at oracle.com
Fri Feb 20 05:03:46 UTC 2015
On 2/19/2015 8:57 PM, Phil Race wrote:
> On 2/19/15 8:50 PM, Mandy Chung wrote:
>> On 2/19/2015 4:23 PM, Phil Race wrote:
>> I'll let Sherman and others to do the detailed review here. Minor
>> line 56-58: can use try-with-resource.
> Its a ByteArrayInputStream there is no leak potential
line 60 catches my attention even no leak potential.
>> line 62: should it throw UncheckedIOException?
> Completely theoretical as far as I can tell.
>>> With this change, for the benefit of jigsaw, the Charset support
>>> needed by the font code
>>> now uses just the public APIs.
>> java.desktop to the internal of charsets is an undesirable edge in
>> the module graph . Thank you for eliminating it. It's not ideal
>> to copy sun.nio code while some day these sun.awt.motif.** will no
>> longer be needed and can be removed.
>> With this dependency removed, <top-repo>/modules.xml needs to be
>> updated. Here is the patch:
> I wondered who would do this but if you want it part of this patch, no
> problem I can include it.
Yes please and make verify-modules to verify the dependencies.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev