[OpenJDK 2D-Dev] Review Request JDK-8129457: Disposer.pollRemove may fail to dispose

Phil Race philip.race at oracle.com
Wed Jul 1 18:01:07 UTC 2015

I think it looks fine.
Writing a test for this that is reliable in proving the bug was there and
is now fixed, and does not access any internals looks challenging.
I would opt for noreg-hard on this one.


On 06/29/2015 02:09 AM, Sergey Bylokhov wrote:
> HI, Prasanta.
> The fix looks fine, but is it possible to write a test for it?
> On 29.06.15 9:46, prasanta sadhukhan wrote:
>> Gentle reminder for review of this small fix.
>> Regards
>> Prasanta
>> On 6/24/2015 2:34 PM, prasanta sadhukhan wrote:
>>> Hi,
>>> Please review a small fix for this issue where it seems if polling 
>>> is performed before the bounds are checked then it may happen that 
>>> "obj" maybe removed from queue without getting disposed if the 
>>> bounds checks are exceeded. Fix is to check for bounds before 
>>> polling the queue to remove the object so that we can bail out if 
>>> bounds are exceeded before obj is removed from queue.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8129457
>>> Webrev: http://cr.openjdk.java.net/~psadhukhan/8129457/webrev.00/
>>> Regards
>>> Prasanta

More information about the 2d-dev mailing list