[OpenJDK 2D-Dev] [9] Review request for 8076545 Text size is twice bigger under Windows L&F on Win 8.1 with HiDPI display

Phil Race philip.race at oracle.com
Wed Jul 8 23:32:11 UTC 2015


- Note that the size you are re-scaling is the real pixel size GDI says 
to use,
   so this is presumably to prevent double-scaling ? I can't really tell 
   the attached images if the size the user perceives in the Win L&F is
   the same as the rest of the native desktop or much bigger.
   In other words is Win L&F just right and Metal too small, or is
   Metal just right and Win L&F too big ?

- why use ceil instead of rounding ? For 120 dpi and a reported 14 pixel 
font you
probably want the closest int to "11.2" which is 11 but you will return 12.

- I am not familiar with what the effect is of the change in 
   Can you explain this.

- Sergey's point about multi-mon should be checked out.


On 7/3/2015 10:06 AM, Alexander Scherbatiy wrote:
> Hello,
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8076545
>   webrev: http://cr.openjdk.java.net/~alexsch/8076545/webrev.00
>   Windows L&F fonts and size of components are rescaled according to 
> the system DPI.
> Thanks,
> Alexandr.

More information about the 2d-dev mailing list