[OpenJDK 2D-Dev] <OpenJDK 2D-Dev> Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header
Jayathirth D V
jayathirth.d.v at oracle.com
Mon Nov 23 11:41:04 UTC 2015
Thanks for suggestion. I have made related changes and updated the Webrev.
Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/
From: prasanta sadhukhan
Sent: Monday, November 23, 2015 4:43 PM
To: Jayathirth D V; 2d-dev at openjdk.java.net
Cc: Philip Race
Subject: Re: <OpenJDK 2D-Dev> Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header
Looks ok to me.
But probably you could check for image width &height programmatically instead of hardcoding to 64 in testcode.
On 11/23/2015 4:09 PM, Jayathirth D V wrote:
Please review following fix in JDK9:
Bug : https://bugs.openjdk.java.net/browse/JDK-8041501
Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8041501/webrev.00/"http://cr.openjdk.java.net/~jdv/8041501/webrev.00/
Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling.
Root cause : We are overriding JPEG color space set in IJG library at imageioJPEG.c without checking component ID's properly when JFIF & EXIF are not there. Decision to change color space is solely done consulting sampling factors.
Solution : Added extra check to verify component ID's also before changing color space determined by IJG library when there is no JFIF & EXIF header.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev