[OpenJDK 2D-Dev] [9] RFR: JDK-8154057, , [macosx] getPrintJob doesn't throw NPE if Frame is null AND type is COMMON

Phil Race philip.race at oracle.com
Tue Apr 12 17:03:34 UTC 2016

Sorry not this one

I meant a different review 


On 04/12/2016 10:02 AM, Phil Race wrote:
> please resubmit this review request with the bug id in the subject line.
> -phil.
> On 04/12/2016 04:16 AM, prasanta sadhukhan wrote:
>> Hi All,
>> Please review a fix for jdk9.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154057
>> webrev: http://cr.openjdk.java.net/~psadhukhan/8154057/webrev.00/
>> As per spec, Toolkit.getPrintJob() should throw NPE if null frame 
>> object is passed to it.
>> But on macos, it seems getPrintJob() does not check for null frame 
>> and show the print dialog.
>> Fix is to check for null frame which is same as what we do in windows 
>> (WToolkit) and linux (XToolkit).
>> Regards
>> Prasanta

More information about the 2d-dev mailing list