[OpenJDK 2D-Dev] [9] Review request for 8142966 Wrong cursor position in text components on HiDPI display

Phil Race philip.race at oracle.com
Fri Feb 5 19:39:21 UTC 2016

Two things strike me when I read this

1) Initial surprise at how deep into the font code it goes.
Perhaps there are alternatives.

2) That it changes to using the linear metrics for measuring advance.
Regardless of (1) I do not think (2) is correct. I am fairly sure this
will lead to changes in text advance. It seems like it must throw
away adjusted metrics as a result of glyph hinting.

I don't know what the fix should be, since I have not looked at the
problem top-down, I am just seeing the bottom-up proposed solution.
So all I can say for now is that it needs to be at least somewhat different.


On 01/27/2016 01:26 PM, Alexander Scherbatiy wrote:
> Hello,
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8142966
>   webrev: http://cr.openjdk.java.net/~alexsch/8142966/webev.00/
>  The proposed fix rounds a glyph advance first and then scales it if 
> UI scales do not equal to one.
>  Thanks,
>  Alexandr.

More information about the 2d-dev mailing list