[OpenJDK 2D-Dev] RFR 8149338: JVM Crash caused by Marlin renderer not handling NaN coordinates

Jim Graham james.graham at oracle.com
Mon Feb 8 23:14:24 UTC 2016

In the test case, why are you using a log handler to check for a 
particular exception?  Shouldn't any exception logged be cause for a 
test failure?


On 2/8/16 1:22 PM, Laurent Bourgès wrote:
> Phil & Jim,
> Please review a simple fix for a SEGV in Marlin renderer due to NaN
> coordinates:
> bug: https://bugs.openjdk.java.net/browse/JDK-8149338
> webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8149338.0/
> Changes:
> - addLine: use first / last Y crossings to compute edge min/max Y that
> ensures consistency with edgeBuckets / edgeBucketCounts arrays in case
> of NaN values: it is used in dispose() to reset these critical arrays
> (pointer-like) => robust and consistent zero-fill
> - minor cleanup in closePath() to avoid upscaling coordinates
> - added crash test
> Cheers,
> Laurent

More information about the 2d-dev mailing list