[OpenJDK 2D-Dev] JDK 9 RFR of JDK-8149896: Remove unnecessary values in FloatConsts and DoubleConsts

Laurent Bourgès bourges.laurent at gmail.com
Tue Feb 16 10:08:53 UTC 2016


Joe, I tested your changes in the Marlin renderer as it works well !

> A quick note on the 2d changes, several constants (and a copy from a
> package-private method from java.lang) were used to initialize a double
> value POWER_2_TO_32; this can be accomplished more directly using a
> hexadecimal floating-point literal.
> >
> > Please review the webrev
> >
> >    http://cr.openjdk.java.net/~darcy/8149896.0/
> ...
> My favourite change is this one:
> -    private static final double POWER_2_TO_32 = FloatMath.powerOfTwoD(32);
> +    private static final double POWER_2_TO_32 = 0x1.0p32;
> and the removal of the method on FloatMath.

I agree it is simpler and exactly what I needed; I wasn't aware of such

(I am not a reviewer)

Thanks for the fix,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160216/1464f28f/attachment.html>

More information about the 2d-dev mailing list