[OpenJDK 2D-Dev] Fix integer overflow warnings in icu layout code
omajid at redhat.com
Wed Feb 17 15:45:44 UTC 2016
* Omair Majid <omajid at redhat.com> [2016-01-27 15:35]:
> * Phil Race <philip.race at oracle.com> [2016-01-21 17:55]:
> > On 01/21/2016 01:50 PM, Omair Majid wrote:
> > >That said, do you think some sort of add-and-check-for-overflow test
> > >would be suitable here? I can take a shot at implementing it, if you
> > >like.
> > Sure ! (to the code change option).
> The following webrev implements that:
> It uses comparisons with INT32_MAX and INT32_MIN instead of performing
> an addition or subtraction on the variable itself to avoid an overflow.
> With this, I no longer get any overflow warnings.
> On the other hand, if you think these checks are redundant, then I would
> be happy to remove these too.
Ping. Anyone have any comments?
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681
More information about the 2d-dev