[OpenJDK 2D-Dev]  RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java
prasanta.sadhukhan at oracle.com
Fri Feb 19 09:18:41 UTC 2016
Hi Phil, All,
It was seen after fix of JDK-8061267
Specified Page Ranges not displayed in Windows Native Print Dialog
the closed/java/awt/PrintJob/HighResTest/HighResTest.java was failing
with NPE when PrinterJob.getGraphics() is called the 2nd time before
The above fix caused this regression because it sets the PD_PAGENUMS
flag for windows PrintDlg struct which causes *Pages* radio button to be
selected in print dialog.
However, fromPage and toPage was both set to 1 so after the 1st page is
printed, RasterPrinterJob.print(attributes) finishes and
graphicsToBeDrawn.closeWhenEmpty() gets called
which sets the queue to null so when PrinterJob2D#getGraphics() calls
graphicsToBeDrawn.pop() it sees queue to be null and sets graphics
object to be null so
PrinterJob.getGraphics() gets null and g.drawLine in testcase causes NPE
since g is null.
Fix was done to set the PD_PAGENUMS flag only when toPage is more than
fromPage in which case, "All" will be selected in printer dialog and
RasterPrinterJob.print() will finish only after printing all the pages.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev