[OpenJDK 2D-Dev]  RFR: JDK-8164971: PNG metadata does not handle ImageCreationTime
brian.burkhalter at oracle.com
Fri Aug 18 19:26:51 UTC 2017
This review is with respect to . Picky comments:
479, 570, 667: Add space around the “-“ signs.
741, 752, 757 and in other files: In general, comments starting with “/*” should be blank after the “/*” with the actual verbiage starting on the next line.
What about the PNG ImageWriter? The description in the issue  implies that the the ImageCreationTime should be used to set the Creation Time in the text chunk(s). Or is this already happening?
On Jul 20, 2017, at 7:27 AM, Prahalad Kumar Narayanan <prahalad.kumar.narayanan at oracle.com> wrote:
> First, Thanks to Brian and Jay for their time in review & feedback.
> . I 've addressed the review suggestions and the updated code is available for review.
> . Webrev Link: http://cr.openjdk.java.net/~pnarayanan/8164971/webrev.01/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev