[OpenJDK 2D-Dev] [10]JDK-8183341:Better cleanup for javax/imageio/AllowSearch.java

Sergey Bylokhov sergey.bylokhov at oracle.com
Tue Jul 11 18:43:24 UTC 2017

Hi Shashi. 
I suggest to add a finally to the try block in the test() method and delete the file, close the stream and close the reader there. 

----- shashidhara.veerabhadraiah at oracle.com wrote: 
> [10]JDK-8183341:Better cleanup for javax/imageio/AllowSearch.java 

Hi All, 

Please review a fix for a test bug which was not cleaning up the temporary test files that it used to create . 

The issue with this test was that the test used to create temporary files but not deleting them. 

The updated test file does the deletion of the temporary files that the test is creating . 


< https://bugs.openjdk.java.net/browse/JDK-8183341 > 


< http://cr.openjdk.java.net/~pkbalakr/shashi/8183341/webrev_00/ > 

Note: The user had requ ested to create the temporary files in user.dir. But I think it is good to create the temporary files in the system temp directory and use it for testing and later delete the same. Besides if required the user has the choice to change the temp directory to the directory they wish for. 

Thanks and regards, 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20170711/bdb2a497/attachment.html>

More information about the 2d-dev mailing list