[OpenJDK 2D-Dev] RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure
erik.joelsson at oracle.com
Thu Mar 15 14:20:38 UTC 2018
Looks good to me. I tried cleaning this up before but failed to find a
reasonable split, but this seems like a good split between common and
On 2018-03-14 18:12, Magnus Ihse Bursie wrote:
> I forgot to add the client mailing lists as recipients. Sorry. (Not
> sure if "sounds" belong to "awt" or "2d".)
> On 2018-03-15 02:07, Magnus Ihse Bursie wrote:
>> From the bug description:
>> Moving this to a separate bug from JDK-8055190. In
>> SoundLibraries.gmk, the source code splitting is not complete. The
>> directory libjsound is used to build not only libjsound but
>> libjsoundalsa and libjsoundds, and thus needs a complex
>> include/exclude system like before.
>> I have tested this using COMPARE_BUILD. Windows and solaris are
>> completely clean. On macosx, there's a binary diff (but nothing else)
>> on libjsound.dylib. On linux, some offset seems to have changed,
>> which caused a slight change in disass and fulldump for libjsound.so.
>> I'm not quite sure what's causing it, but I'm convinced it's harmless.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8071469
More information about the 2d-dev