[OpenJDK 2D-Dev]  RFR JDK-8139178: Wrong fontMetrics when printing in Landscape
abrygin at azul.com
Fri Nov 30 06:52:31 UTC 2018
> On Nov 30, 2018, at 6:27 AM, Philip Race <philip.race at oracle.com> wrote:
> I'd like to get this one in before 12 forks .. very soon .. are you going to
> be able to get this in ?
yes, I had updated the fix according to your comments, and, with your permission,
I am ready to push it into the client repo:
Or do I have to use jdk-submit instead?
I had posted the updated change some time ago, but there was no response…
> On 11/16/18, 1:10 PM, Phil Race wrote:
>> Looks good to me. Just some nits.
>> Can we split the long lines like this ? :-
>> #define contextAwareMetricsX(vx, vy) \
>> (FTFixedToFloat(context->transform.xx) * (vx) - \
>> FTFixedToFloat(context->transform.xy) * (vy))
>> and why "vx" and "vy", not just x and y ?
>> On 11/10/18 8:53 AM, Andrew Brygin wrote:
>>> could you please review a fix for JDK-8139178.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139178
>>> Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/
>>> The freetype scaler calculates font metrics with a transform
>>> applied to the scaler context. We have to revert this transform
>>> in order to get correct font metrics.
More information about the 2d-dev