[OpenJDK 2D-Dev] [8u] RFR 8201801: RTL language (Hebrew) is presented from left to right
dmitry.markov at oracle.com
Mon Sep 3 12:54:54 UTC 2018
Thank you for the feedback. I missed the usage of OSX specific class in shared code for some reasons. Please find the updated webrev here: http://cr.openjdk.java.net/~dmarkov/8201801/jdk8u/webrev.01/
I replaced the usage of CFont with a new private method which tests either a font is AAT or not.
The issue is jdk8u (ICU) specific. It does not take place on jdk12 because starting from jdk9 we use Harfbuzz as default layout engine.
> On 3 Sep 2018, at 11:33, Prasanta Sadhukhan <prasanta.sadhukhan at oracle.com> wrote:
> Hi Dmitry,
> Not going into technicalities of the fix, but it seems it will break non-macos build as you are checking for CFont in a shared class?
> Also, if it's the issue still exists, then why you are fixing only in 8u and not in jdk12?
> On 9/3/2018 3:20 PM, Dmitry Markov wrote:
>> Could you review a fix for jdk8u, please?
>> bug: https://bugs.openjdk.java.net/browse/JDK-8201801 <https://bugs.openjdk.java.net/browse/JDK-8201801>
>> webrev: http://cr.openjdk.java.net/~dmarkov/8201801/jdk8u/webrev.00/ <http://cr.openjdk.java.net/%7Edmarkov/8201801/jdk8u/webrev.00/>
>> Problem description:
>> The fix for 7162125  enabled font tables processing on OSX. However there is a lack of support for RTL languages in ICU layout engine. Quote from ICU guide: “…The AAT processing in the LayoutEngine is relatively basic as it only applies the default features in left-to-right text. This processing has been tested for Devanagari text. Since AAT processing is not script-specific, it might not work for other scripts…”, more details at http://userguide.icu-project.org/layoutengine <http://userguide.icu-project.org/layoutengine>
>> As a result all RTL languages on OSX are incorrectly laid out, (i.e. the letters are reversely presented).
>> Skip font tables for RTL languages on OSX platform.
>>  - https://bugs.openjdk.java.net/browse/JDK-7162125 <https://bugs.openjdk.java.net/browse/JDK-7162125>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev