[OpenJDK 2D-Dev] RFR [12] Clipping problems with complex affine transforms: negative scaling factors or small scaling factors

Philip Race philip.race at oracle.com
Wed Sep 5 23:39:22 UTC 2018

This looks good to me.
I've run all our automated tests + done some manual testing
as well as building on all platforms and reviewing the source changes.

 >  PS: What is the process to ask for backport to JDK11 updates ?

If you think this important enough to backport, then this is the process :



On 9/4/18, 1:45 PM, Laurent Bourgès wrote:
> Please review this bug fix for the Marlin renderer (introduced in 10):
> JBS: https://bugs.openjdk.java.net/browse/JDK-8210335
> webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8210335.0/ 
> <http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8210335.0/>
> Changes:
> - clipping rectangle is adjusted to take into account the inverse 
> transform (scale/shear)
> - MarlinRenderingEngine: prepare once the clip with small margin + 
> renderer offset
> - TransformingPathConsumer2D:
>     - missing min < max in adjustClipScale() if scale < 0
>    - compute mean inverse scale factor to be used in CurveClipSplitter 
> to perform proper length checks to avoid too many subdivision
> PS: What is the process to ask for backport to JDK11 updates ?
> Cheers,
> Laurent

More information about the 2d-dev mailing list