[OpenJDK 2D-Dev] [13] Review Request: 8222917 GraphicsEnvironment for Unix still have an unused dependency on Solaris

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Apr 24 07:35:50 UTC 2019

Please review the fix for JDK 13.

Bug: https://bugs.openjdk.java.net/browse/JDK-8222917
Fix: http://cr.openjdk.java.net/~serb/8222917/webrev.00

The SunGraphicsEnvironment has a codepath for the OpenSolaris, but in fact results on this execution is never used.
This code was added in JDK-6378099:
But the usage of isOpenSolaris flag was dropped in JDK-6795908:

In this fix, the unused code was removed.

BTW I am not sure why we set the default font for SG2D in the constructor of SunGraphicsEnvironment and not assign the field directly? Probably the reason is related to some cyclic dependency?.

Best regards, Sergey.

More information about the 2d-dev mailing list