[OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Roger Riggs Roger.Riggs at oracle.com
Fri Jul 12 18:17:38 UTC 2019

Hi Brian,

Would it be appropriate to add @Override to the new method (and perhaps 
existing overridden methods).

Previously, calling FilterOutputStream.write(byte[]) would delegate to 
write(byte[], 0, length).
The proposed change duplicates the code and changes the ways that 
overridden classes might see the call.
What's the benefit of duplicating the code and calling out.write(buf)?

Not my call, but in PSPrinterJob.java (970-977) it might be cleaner to 
just delete the unused code and comment.

(The CSR will need to note the source incompatibility due to the removal 
of a declared exception)

Thanks, Roger

On 7/11/19 1:44 PM, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8187898
> http://cr.openjdk.java.net/~bpb/8187898/webrev.00/
> Override FilterOutputStream.write(byte[]) not to throw IOException. Including 2d-dev as this creates a source compatibility issue in PSPrinterJob which I fix in this patch.
> A CSR would of course be needed for this.
> Thanks,
> Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20190712/c7ca8ec1/attachment-0001.html>

More information about the 2d-dev mailing list