[OpenJDK 2D-Dev] RFR: 8249821: Separate libharfbuzz from libfontmanager
erik.joelsson at oracle.com
Wed Jul 22 12:45:08 UTC 2020
Looks good, thanks!
On 2020-07-21 15:18, Philip Race wrote:
> I noticed the indent problems at 434 & 436 myself once I looked at it
> as a webrev,
> so I was already updating the fix with those but I've also fixed the
> rest you pointed out.
> I've uploaded a new webrev with all of these resolved :-
> On 7/21/20, 3:03 PM, Erik Joelsson wrote:
>> Hello Phil,
>> This looks pretty good, only some style nits.
>> 428 and 466: These comments aren't relevant anymore now that harfbuzz
>> is its own library.
>> 434: Missed indent of 2
>> 436: Too much indent (should be 2)
>> 459-464: Too much indent
>> 493-494: Too much indent
>> On 2020-07-21 14:39, Philip Race wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8249821
>>> Webrev: http://cr.openjdk.java.net/~prr/8249821/
>>> This fix breaks out libharfbuzz from libfontmanager.
>>> As well as building I've done extensive testing on all platforms.
>>> I have tweaked the disabled warnings so we don't have un-needed
>>> but it is not a goal of this fix to resolve them.
>>> There's a bug (JDK-8074844) already filed to resolve them for
>>> fontmanager and
>>> that should be easier to fix now.
More information about the 2d-dev