[OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins

Kumar Abhishek kumar.z.abhishek at oracle.com
Fri Jul 24 10:08:11 UTC 2020


Hi Phil,


This bug was originally only for JPEG plugin though I have verified the changes for other plugins as well.

Do you want me to divide the change for different plugins and create separate bugs or the current approach is fine?


Please find the updated webrev with superfluous comments removed :






From: Philip Race 
Sent: Thursday, July 23, 2020 10:37 PM
To: Kumar Abhishek <kumar.z.abhishek at oracle.com>
Cc: 2d-dev at openjdk.java.net
Subject: Re: [OpenJDK 2D-Dev] RFR : 8200281: Add missing @Override annotations in ImageIO plugins


On 7/23/20, 5:20 AM, Kumar Abhishek wrote: 


Hello, Please review this small change for JDK-16 .
This is a clean up task to verify and add missing annotations in ImageIO plugins

They are missing in part because most of these classes were added in 1.4 and
annotations were introduced in 1.5. So I am not sure how much retrofitting we
should do along these lines. If applied widely it could just make backports painful
when patches will not apply.

     /** Overrides the method defined in the superclass. */
+    @Override

The comment is now superflous so I suggest to remove it in the couple of places it is present.


Verified and added annotations for all the Writer and Reader implementation under src/java.desktop/share/classes/com/sun/imageio/plugins/
Bug/webrev :
HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8200281/webrev.00/"http://cr.openjdk.java.net/~jdv/8200281/webrev.00/ 
Thanks, Abhishek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/2d-dev/attachments/20200724/bc8bc6ff/attachment.htm>

More information about the 2d-dev mailing list