[OpenJDK 2D-Dev] RFR: 8250894 : Provide a configure option to build and run against the platform libharfbuzz
philip.race at oracle.com
Fri Jul 31 19:56:03 UTC 2020
Done : http://cr.openjdk.java.net/~prr/8250894.1/
Although it makes the webrev noisier ..
On 7/31/20, 11:48 AM, Erik Joelsson wrote:
> Hello Phil,
> Looks good. The only thing I would ask is that you indent everything
> in the else clause in Awt2dLibraries.gmk.
> On 2020-07-31 10:58, Philip Race wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8250894
>> webrev : http://cr.openjdk.java.net/~prr/8250894/
>> Since https://bugs.openjdk.java.net/browse/JDK-8249821 has now separated
>> out libharfbuzz from libfontmanager, it would be natural for distros
>> to want to link against the libharfbuzz that they distribute with the
>> platform, as is done for libfreetype. But there is no way to do it.
>> This fix adds a --with-harfbuzz=system configure option.
>> The valid values are system and bundled.
>> If specifying system it checks to see if you have the harfbuzz
>> development package installed
>> Like similar options it is only useful on platforms that distribute
>> libharfbuzz, so there is no need to try to support windows and macOS
>> for this option
>> and it will fast fail at configure time on those platforms.
>> I have verified this fix on Ubuntu 20.04 LTS.
More information about the 2d-dev