[OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
ajit.ghaisas at oracle.com
Tue Sep 1 10:42:49 UTC 2020
> On 26-Aug-2020, at 5:05 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> On 25.08.2020 14:59, Philip Race wrote:
>> This is fine but
>> 1) I like to see the bug under which you fixed it in the @bug list.
> It is not a product bug and the test isn't reworked, so it is not necessary to have this test fix in the list of bugs
>> 2) I am not sure I see how all the various reasons for this test failing can be explained by this.
> In the HiDPI mode the VolatileImage internally have twice more pixels than BufferedImage, so when we draw the data to
> the VolatileImage and then scale it back to the size of the BufferedImage for comparison, the test fails.
This looks good. I checked with OGL and Metal (project Lanai) on macOS.
One question is - do we need to support this test in HiDPI mode?
>> On 8/25/20, 1:37 PM, Sergey Bylokhov wrote:
>>> Please review the fix for jdk/client.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8171303
>>> Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00
>>> This the only test which was created to check different types of interpolation.
>>> It checks the rendering to the VolatileImage and uses BufferedImage as a gold image.
>>> But it does not take into account that rendering to the VolatileImage might be affected
>>> by the HiDPI support.
> Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev