[OpenJDK 2D-Dev] RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase
dholmes at openjdk.java.net
Thu Sep 10 11:24:10 UTC 2020
On Thu, 10 Sep 2020 10:40:15 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> @kevinrushforth thanks. Done.
>> Similar issues:
>> could be joined somehow?
> The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
> the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
> more than half are in tests. It would be good to hear from security-dev on the changes to the Apache Santuario code
> (in java.xml.crypto module) in case it would be better to contribute those upstream instead. Ditto for the Apache Xalan
> code (in the java.xml module) but it may be significantly forked already that it doesn't matter. I assume you can use
> JDK-8215014 rather than creating a new issue.
This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
More information about the 2d-dev