[OpenJDK 2D-Dev] RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase
david.holmes at oracle.com
Thu Sep 10 13:50:22 UTC 2020
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote:
> On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
>>> The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do
>>> the same in the java.desktop module (JDK-8223237). Changing the remaining usages make sense although I see that more
>>> more than half are in tests. It would be good to hear from security-dev on the changes to the Apache Santuario code
>>> (in java.xml.crypto module) in case it would be better to contribute those upstream instead. Ditto for the Apache Xalan
>>> code (in the java.xml module) but it may be significantly forked already that it doesn't matter. I assume you can use
>>> JDK-8215014 rather than creating a new issue.
>> This should be broken up to deal with the files in different functional areas under different bugids and PRs. Otherwise
>> the cross-posting to so many lists is prohibitive. Files in different areas need to be reviewed by different teams.
>> Thank you.
> I have in mind dozens of improvements all over the code like this one. I already did some further review and in most
> cases, those tiny changes go trough all codebase. I can create PR for every separate module, but in general, it would
> multiply x5 the number of PRs in total. If you think it's a better way to go, no problem, I can do that.
Find a reasonable middle ground. You have around 14 mailing lists cc'd
here, for changes on 150 files. It is very unlikely anyone will review
all 150, and files in different areas are, by convention, reviewed by
Reviewers for those areas. Even if people only look at a subset of
files, communicating that to you effectively so you can figure out when
all 150 have been reviewed, is not very practical.
My initial breakdown would be:
- desktop (awt/swing/2d)
- serviceability/jmx (the SA and JVMTI changes)
Also note that while the original PR email went out to 14 lists, most
people trying to reply-all won't be able to as they don't subscribe to
all 14 lists, so the review threads will get very fragmented.
> PR: https://git.openjdk.java.net/jdk/pull/29
More information about the 2d-dev